Closed keithchong closed 1 year ago
Patch coverage: 50.00
% and project coverage change: +0.01
:tada:
Comparison is base (
91b47ef
) 58.58% compared to head (01d5e7d
) 58.59%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi @keithchong , Thanks for the PR. @chetan-rns will be able to review this PR ?
@wtam2018 can you please merge this ?
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: wtam2018
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/ok-to-test
/retest
/lgtm
The go version that is being used is 1.16 and I think we need 1.18
go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/go/.cache" GOENV="/alabama/.config/go/env" GOEXE="" GOFLAGS="-mod=vendor" GOHOSTARCH="amd64" GOHOSTOS="linux" GOINSECURE="" GOMODCACHE="/go/pkg/mod" GONOPROXY="" GONOSUMDB="" GOOS="linux" GOPATH="/go" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/usr/local/go" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64" GOVCS="" GOVERSION="go1.16.12" GCCGO="gccgo" AR="ar" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="/go/src/github.com/redhat-developer/kam/go.mod" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build2469114545=/tmp/go-build -gno-record-gcc-switches"
Oh yeah. @varshab1210 The OpenShift CI needs to upgrade go.
The original error message isn't quite useful:
error: failed to execute wrapped command: exit status 2
I believe the underlying error message is:
go.mod file indicates go 1.18, but maximum supported version is 1.16
The original error message isn't quite useful:
error: failed to execute wrapped command: exit status 2
I believe the underlying error message is:
go.mod file indicates go 1.18, but maximum supported version is 1.16
Thanks @keithchong, good catch. I will raise a PR
/retest
@keithchong: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/v4.8-integration-e2e | 26d62ed6537f3deacddd14235baa5a827e11a986 | link | true | /test v4.8-integration-e2e |
Full PR test history. Your PR dashboard.
/retest
/lgtm
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
See Jira https://issues.redhat.com/browse/GITOPS-2337 Documentation has not been updated. Code changes only for now.
How to test changes / Special notes to the reviewer: Untested PR. MUST test with pipelines feature with kam after bootstrapping steps (Do day 1 and 2 operations)