redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

Update to OS Pipelines 1.10 and k8s dependencies (#2337) #337

Closed keithchong closed 1 year ago

keithchong commented 1 year ago

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:

Have you updated the necessary documentation?

Which issue(s) this PR fixes:

Fixes #?

See Jira https://issues.redhat.com/browse/GITOPS-2337 Documentation has not been updated. Code changes only for now.

How to test changes / Special notes to the reviewer: Untested PR. MUST test with pipelines feature with kam after bootstrapping steps (Do day 1 and 2 operations)

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.01 :tada:

Comparison is base (91b47ef) 58.58% compared to head (01d5e7d) 58.59%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #337 +/- ## ========================================== + Coverage 58.58% 58.59% +0.01% ========================================== Files 57 57 Lines 2888 2884 -4 ========================================== - Hits 1692 1690 -2 + Misses 1030 1028 -2 Partials 166 166 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `58.59% <50.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/redhat-developer/kam/pull/337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer) | Coverage Δ | | |---|---|---| | [pkg/pipelines/tasks/set\_commit\_status\_task.go](https://codecov.io/gh/redhat-developer/kam/pull/337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer#diff-cGtnL3BpcGVsaW5lcy90YXNrcy9zZXRfY29tbWl0X3N0YXR1c190YXNrLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/pipelines/git/repository.go](https://codecov.io/gh/redhat-developer/kam/pull/337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer#diff-cGtnL3BpcGVsaW5lcy9naXQvcmVwb3NpdG9yeS5nbw==) | `66.66% <100.00%> (ø)` | | | [pkg/pipelines/tasks/deploy\_from\_source\_task.go](https://codecov.io/gh/redhat-developer/kam/pull/337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer#diff-cGtnL3BpcGVsaW5lcy90YXNrcy9kZXBsb3lfZnJvbV9zb3VyY2VfdGFzay5nbw==) | `100.00% <100.00%> (ø)` | | | [pkg/pipelines/triggers/pipelinerun.go](https://codecov.io/gh/redhat-developer/kam/pull/337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer#diff-cGtnL3BpcGVsaW5lcy90cmlnZ2Vycy9waXBlbGluZXJ1bi5nbw==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

iam-veeramalla commented 1 year ago

Hi @keithchong , Thanks for the PR. @chetan-rns will be able to review this PR ?

iam-veeramalla commented 1 year ago

@wtam2018 can you please merge this ?

wtam2018 commented 1 year ago

/approve /lgtm

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wtam2018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)~~ [wtam2018] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
wtam2018 commented 1 year ago

/ok-to-test

varshab1210 commented 1 year ago

/retest

wtam2018 commented 1 year ago

/lgtm

keithchong commented 1 year ago

The go version that is being used is 1.16 and I think we need 1.18

go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/go/.cache" GOENV="/alabama/.config/go/env" GOEXE="" GOFLAGS="-mod=vendor" GOHOSTARCH="amd64" GOHOSTOS="linux" GOINSECURE="" GOMODCACHE="/go/pkg/mod" GONOPROXY="" GONOSUMDB="" GOOS="linux" GOPATH="/go" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/usr/local/go" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64" GOVCS="" GOVERSION="go1.16.12" GCCGO="gccgo" AR="ar" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="/go/src/github.com/redhat-developer/kam/go.mod" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build2469114545=/tmp/go-build -gno-record-gcc-switches"

wtam2018 commented 1 year ago

Oh yeah. @varshab1210 The OpenShift CI needs to upgrade go.

keithchong commented 1 year ago

The original error message isn't quite useful:

error: failed to execute wrapped command: exit status 2

I believe the underlying error message is:

go.mod file indicates go 1.18, but maximum supported version is 1.16

varshab1210 commented 1 year ago

The original error message isn't quite useful:

error: failed to execute wrapped command: exit status 2

I believe the underlying error message is:

go.mod file indicates go 1.18, but maximum supported version is 1.16

Thanks @keithchong, good catch. I will raise a PR

varshab1210 commented 1 year ago

/retest

openshift-ci[bot] commented 1 year ago

@keithchong: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.8-integration-e2e 26d62ed6537f3deacddd14235baa5a827e11a986 link true /test v4.8-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
wtam2018 commented 1 year ago

/retest

wtam2018 commented 1 year ago

/lgtm