redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

CI:Updating golang version to 1.18 #339

Closed varshab1210 closed 1 year ago

varshab1210 commented 1 year ago

What type of PR is this?

Uncomment only one /kind line, and delete the rest. For example, > /kind bug would simply become: /kind bug

/kind bug /kind cleanup /kind failing-test /kind enhancement /kind documentation /kind code-refactoring

What does this PR do / why we need it:

Have you updated the necessary documentation?

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (91b47ef) 58.58% compared to head (5ac5327) 58.58%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #339 +/- ## ======================================= Coverage 58.58% 58.58% ======================================= Files 57 57 Lines 2888 2888 ======================================= Hits 1692 1692 Misses 1030 1030 Partials 166 166 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `58.58% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

chetan-rns commented 1 year ago

@varshab1210 Could you also update the version in the README?

https://github.com/redhat-developer/kam#how-to-contribute

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wtam2018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)~~ [wtam2018] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
varshab1210 commented 1 year ago

/test v4.10-integration-e2e

varshab1210 commented 1 year ago

/retest

varshab1210 commented 1 year ago

/retest