redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

Do away with HTTP server and instead used a Go based File server for hosting binaries #346

Open anandf opened 1 year ago

anandf commented 1 year ago

What type of PR is this? /kind enhancement

What does this PR do / why we need it: The kam container image uses httpd base image which requires frequent updates for CVE fixes and is difficult to maintain. By using a Go based fileserver for hosting the binaries for different OS and architecture, we can do away with HTTP server and instead use a light weight image. Even a scratch base image should be enough for running a go binary.

Have you updated the necessary documentation?

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

openshift-merge-robot commented 1 year ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9babd9f) 58.61% compared to head (6dd6ce2) 58.61%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #346 +/- ## ======================================= Coverage 58.61% 58.61% ======================================= Files 57 57 Lines 2885 2885 ======================================= Hits 1691 1691 Misses 1028 1028 Partials 166 166 ``` | [Flag](https://app.codecov.io/gh/redhat-developer/kam/pull/346/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/redhat-developer/kam/pull/346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer) | `58.61% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wtam2018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)~~ [wtam2018] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.61%. Comparing base (9babd9f) to head (6dd6ce2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #346 +/- ## ======================================= Coverage 58.61% 58.61% ======================================= Files 57 57 Lines 2885 2885 ======================================= Hits 1691 1691 Misses 1028 1028 Partials 166 166 ``` | [Flag](https://app.codecov.io/gh/redhat-developer/kam/pull/346/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/redhat-developer/kam/pull/346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer) | `58.61% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.