search

redhat-developer / lsp4ij

LSP Client for IntelliJ
Eclipse Public License 2.0
48 stars 9 forks source link

feat: support for 'workspace/configuration' #346

Closed angelozerr closed 3 weeks ago

angelozerr commented 3 weeks ago

feat: support for 'workspace/configuration'

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 12.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 23.72%. Comparing base (f397e11) to head (d1d3b97).

Files Patch % Lines
...hat/devtools/lsp4ij/client/LanguageClientImpl.java 8.33% 22 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #346 +/- ## ========================================== + Coverage 23.41% 23.72% +0.30% ========================================== Files 265 265 Lines 9207 9093 -114 Branches 1677 1243 -434 ========================================== + Hits 2156 2157 +1 + Misses 6644 6529 -115 Partials 407 407 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fbricon commented 3 weeks ago

no exception anymore with the lua LS, but we're now responding with:

[Trace - 12:34:44] Sending response 'workspace/configuration - (1)'. Processing request took 0ms
Result: [
  null,
  null,
  null,
  null,
  null
]

I'm not sure how bad it is, but it's weird. Doesn't seem to break anything with the lua LS so far though.

angelozerr commented 3 weeks ago

It is not weird it follows lsp spec. If you receive N params you need to return N results.