redhat-developer / lsp4ij

LSP Client for IntelliJ
Eclipse Public License 2.0
91 stars 17 forks source link

fix: rootUri must not end with a slash #348

Closed angelozerr closed 3 months ago

angelozerr commented 3 months ago

fix: rootUri must not end with a slash

Params: {
  "rootPath": "/C:/Users/azerr/IdeaProjects/pyright-langserver-for-pycharm-test/",
  "rootUri": "file:///C:/Users/azerr/IdeaProjects/pyright-langserver-for-pycharm-test/",
Params: {
    "rootPath": "c:\\Users\\azerr\\IdeaProjects\\pyright-langserver-for-pycharm-test",
    "rootUri": "file:///c%3A/Users/azerr/IdeaProjects/pyright-langserver-for-pycharm-test",
Params: {
  "rootPath": "C:/Users/azerr/IdeaProjects/pyright-langserver-for-pycharm-test",
  "rootUri": "file:///C:/Users/azerr/IdeaProjects/pyright-langserver-for-pycharm-test",
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 29.16667% with 17 lines in your changes missing coverage. Please review.

Project coverage is 23.57%. Comparing base (28ce1d3) to head (6b4c4d2).

Files Patch % Lines
...in/java/com/redhat/devtools/lsp4ij/LSPIJUtils.java 25.00% 11 Missing and 1 partial :warning:
.../redhat/devtools/lsp4ij/LanguageServerWrapper.java 50.00% 2 Missing and 1 partial :warning:
...hat/devtools/lsp4ij/client/LanguageClientImpl.java 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #348 +/- ## ========================================== - Coverage 23.63% 23.57% -0.06% ========================================== Files 265 265 Lines 9111 9099 -12 Branches 1657 1660 +3 ========================================== - Hits 2153 2145 -8 + Misses 6553 6550 -3 + Partials 405 404 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fbricon commented 3 months ago

thanks @angelozerr!