redhat-developer / lsp4ij

LSP Client for IntelliJ
Eclipse Public License 2.0
91 stars 17 forks source link

[feat] Support to customize icon completion #362

Open CppCXY opened 3 months ago

CppCXY commented 3 months ago

in jetbrain LSP and vscode, it use file icon for file kind: image

but lsp4ij without icon: image

angelozerr commented 3 months ago

but lsp4ij without icon:

In your screenshot, it uses an another file icon from Jetbrains, but there is an icon

We did that at:

https://github.com/redhat-developer/lsp4ij/blob/d4d186ddac757ba121777aa5468bebc1b9e9abda/src/main/java/com/redhat/devtools/lsp4ij/ui/IconMapper.java#L143

If you have a better icon please create a PR.

CppCXY commented 3 months ago

I remembered incorrectly, I customized the icon in JetBrains LSP. So, can LSP4IJ customize icons? image

angelozerr commented 3 months ago

No it is not possible.

We need to provide this support.

angelozerr commented 3 months ago

@CppCXY I target this issue for 0.0.3 since we want to create the release as soon as https://github.com/redhat-developer/lsp4ij/pull/360 will be merged.

Please create a lot of issues i you need to customize another thing to provide the best customization API. Thanks!

CppCXY commented 3 months ago

@CppCXY I target this issue for 0.0.3 since we want to create the release as soon as #360 will be merged.

Please create a lot of issues i you need to customize another thing to provide the best customization API. Thanks!

Thanks, I will release my plugin after you release version 0.0.2. At that time, quite a few people should experience this plugin.

angelozerr commented 3 months ago

Thanks, I will release my plugin after you release version 0.0.2. At that time, quite a few people should experience this plugin.

That's great!

If you like LSP4IJ, could you please:

More we will have LSP4IJ IJ plugin, more we could have contributor and provide the best LSP support for IntelliJ.

fbricon commented 3 months ago

While this doesn't fully cover this request, #365 at least allows to show lua (and others) file completion with the proper icons.