redhat-developer / lsp4ij

LSP Client for IntelliJ
Eclipse Public License 2.0
91 stars 17 forks source link

feat: display platform file icons on completion #365

Closed fbricon closed 3 months ago

fbricon commented 3 months ago

With XML file path support:

Screenshot 2024-06-18 at 13 59 45

and with SumnekoLua (cc @CppCXY):

Screenshot 2024-06-18 at 15 01 11
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 23.56%. Comparing base (cab8091) to head (91415f2).

Files Patch % Lines
...java/com/redhat/devtools/lsp4ij/ui/IconMapper.java 6.66% 13 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #365 +/- ## ========================================== - Coverage 23.64% 23.56% -0.08% ========================================== Files 267 267 Lines 9221 9235 +14 Branches 1686 1265 -421 ========================================== - Hits 2180 2176 -4 - Misses 6634 6653 +19 + Partials 407 406 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

angelozerr commented 3 months ago

It works like a charm! Great job @fbricon !