redhat-developer / lsp4ij

LSP Client for IntelliJ
Eclipse Public License 2.0
48 stars 9 forks source link

fix: The plaintext rendering color on the completion document is too dark. #370

Open angelozerr opened 2 weeks ago

angelozerr commented 2 weeks ago

fix: The plaintext rendering color on the completion document is too dark.

Fixes #368

image

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 24.38%. Comparing base (83ab37a) to head (c1ec7c4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #370 +/- ## ========================================== + Coverage 22.41% 24.38% +1.96% ========================================== Files 270 270 Lines 9725 9408 -317 Branches 1830 1734 -96 ========================================== + Hits 2180 2294 +114 + Misses 7138 6687 -451 - Partials 407 427 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

angelozerr commented 2 weeks ago

I'm trying to write the same lua file than initial issue but the hover doesn't send the same response (param doesn't appear), but I have tested by writing jsdoc in a ts file:

/**
 * ```lua
 function f(a:aa) -> nil
 ```

 ___
 ```plaintext
 params: a
 ```
 ___

 */
function foo() {
}

foo()

And here the result:

image

fbricon commented 2 weeks ago

I think we should keep the code blocks. That's how intellij shows code snippets

Screenshot 2024-06-19 at 15 42 47

LSP4IJ's behavior is consistent with that.

Maybe @CppCXY's issue is the block's background seems darker on completion, compared to hover. Not sure what we can do about it.