Closed angelozerr closed 3 months ago
@FalsePattern please follow this PR, it seems that we do the same thing https://github.com/FalsePattern/ZigBrains/blob/c1f1dd88f14e0c3b631042d92d3880e55670c34c/modules/lsp/src/main/java/com/falsepattern/zigbrains/lsp/contributors/LSPDocumentationLinkHandler.java#L43
Line numbers should be 1-based, as in vscode: L5 should open the 5th line of the file, not the 6th
Line numbers should be 1-based, as in vscode: L5 should open the 5th line of the file, not the 6th
Good catch! It should be fixed now.
@fbricon the PR should work now and I have fixed too the renderer with several links which must be aligned in the same line and not in several lines.
Given this ts file:
/**
Some content...
> and some links:
* [bar.ts](bar.ts#L2:2)
* [lsp4ij](https://github.com/redhat-developer/lsp4ij)
*/
function foo() {
}
foo();
When you hover foo method, links must be aligned in the same line like vscode does:
feat: Support file link in hover
Fixes #376
@CppCXY here a demo with your Lua LS: