search

redhat-developer / mapt

Multi Architecture Provisioning Tool
Apache License 2.0
9 stars 7 forks source link

[BUG] windows desktop sync mechanism #74

Closed adrianriobo closed 3 months ago

adrianriobo commented 1 year ago

We have an scenario where qenvs is used to provision a machine within a pipeline. After the provision task there is a sync task to ensure previously provision task has created the required assets to connect within the target host.

The sync task was not executed after the provisioning but in parallel and it just checked for the output assets generated by qenvs (host, username and key).

The problem is that those files are generated along the execution but not after the healtcheck of the target host is valid. https://github.com/adrianriobo/qenvs/blob/main/pkg/provider/azure/action/windows/windows.go#L136

adrianriobo commented 1 year ago

On one side maybe those assets should not be created unless we can ensure the target host is healthy (so sync based on those output files will work). On the other hand in case of some errors on provisioning we may need those assets to connect and troubleshooting.

For the time being the sync was moved to ensure the sync task is executed after the provision has finished