search

redhat-developer / odo-init-image

ODO v3 no loner users this image!!! (Container for ODO v2 to setup SupervisorD inside S2I builder image.)
Apache License 2.0
7 stars 27 forks source link

Fix permission issues with `rsync -a` #14

Closed anmolbabu closed 5 years ago

anmolbabu commented 5 years ago

Signed-off-by: anmolbabu anmolbudugutta@gmail.com

cdrage commented 5 years ago

Tests seem to be failing?

kadel commented 5 years ago

Tests seem to be failing?

test is failing because this PR requires https://github.com/redhat-developer/odo/pull/1125 to work

anmolbabu commented 5 years ago

Tests seem to be failing?

test is failing because this PR requires redhat-developer/odo#1125 to work

Not sure what that means @kadel Bcoz I see no issues except the ones with permissions in image PR which we resolved

anmolbabu commented 5 years ago

if [ ! -z "${ODO_S2I_WORKING_DIR}" ] && ([ "${ODO_S2I_SRC_BIN_PATH}" != "${ODO_S2I_WORKING_DIR}" ] && [ "${ODO_S2I_DEPLOYMENT_DIR}" != "${ODO_S2I_WORKING_DIR}" ])

kadel commented 5 years ago

we need rsync -rlO (recursive, links, omit dir times)