search

redhat-developer / odo-init-image

ODO v3 no loner users this image!!! (Container for ODO v2 to setup SupervisorD inside S2I builder image.)
Apache License 2.0
7 stars 27 forks source link

fix conditional statements in if condition #17

Closed syamgk closed 5 years ago

syamgk commented 5 years ago

this will fix issue https://github.com/redhat-developer/odo/issues/1231

How to test? Clone this repo odo-supervisord-image and fetch this PR build the image locally and push it to dockerhub for example https://hub.docker.com/r/syamgk/supvisd

then set environment variable and execute the odo comments as below $export ODO_BOOTSTRAPPER_IMAGE='syamgk/supvisd'

$ git clone https://github.com/openshift/nodejs-ex.git
$ odo create nodejs:8 customsupvisrodui --app web --local /tmp/nodejs-ex/
$ odo push
# till here it works fine
# by making changes to source locally and pushing,
$ odo push
# make sure the second push succeeds
anmolbabu commented 5 years ago

Can you please add a corresponding test on odo side? So, that we can be sure that the e2e always covers this edge case for us and we can be sure that it never occurs again Changes LGTM

syamgk commented 5 years ago

@anmol sure I will raise a draft for now and once this is merged we can merge the test on odo side

syamgk commented 5 years ago

tests are failing because of grep keyword mismatch I've pushed a fix for it as well here https://github.com/redhat-developer/odo-supervisord-image/pull/18