search

redhat-developer / odo-init-image

ODO v3 no loner users this image!!! (Container for ODO v2 to setup SupervisorD inside S2I builder image.)
Apache License 2.0
7 stars 27 forks source link

Check if `rsync` is installed or not #22

Closed surajnarwade closed 3 years ago

surajnarwade commented 5 years ago

assemble-and-restart scripts uses rsync, but before that it should whether rsync is installed or not

Reference: https://github.com/openshift/odo/issues/1874#issuecomment-506719433

cdrage commented 5 years ago

See issue: https://github.com/openshift/odo/issues/1609

This has been fixed upstream: https://github.com/sclorg/httpd-container/issues/78

and implemented here: https://github.com/sclorg/s2i-base-container/pull/169

surajnarwade commented 5 years ago

@cdrage , how we can fetch this changes or test changes against new fixes ?

cdrage commented 5 years ago

We should implement this at least to error / use alternative methods if rsync isn't installed. For example.. if there is no rsync copy it over a more "manual" way?

openshift-bot commented 4 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 3 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 3 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot commented 3 years ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/odo-init-image/issues/22#issuecomment-756906992): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.