Clean up naming supervisord-image -> init-image

redhat-developer / odo-init-image

ODO v3 no loner users this image!!! (Container for ODO v2 to setup SupervisorD inside S2I builder image.)

Apache License 2.0

7 stars 27 forks source link

Clean up naming supervisord-image -> init-image #29

Closed kadel closed 5 years ago

kadel commented 5 years ago

This image contains more than supervisord, this updates naming and paths to be more generic to reflect current use.

clean up some unnecessary lines from Dockerfile
use /opt/odo-init/ instead of /opt/supervisord inside the initContainer image
use /opt/odo instead of /var/lib/supervisord insde the builder container

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mohammedzee1000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/odo-supervisord-image/blob/master/OWNERS)~~ [mohammedzee1000] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

amitkrout commented 5 years ago

Ping @girishramnani @mohammedzee1000 @cdrage

amitkrout commented 5 years ago

Ping @girishramnani @mohammedzee1000 @cdrage

@kadel Make sure that travis CI should pass

kadel commented 5 years ago

@kadel Make sure that travis CI should pass

It won't pass as it requires changes in https://github.com/openshift/odo/pull/2027. And tests for https://github.com/openshift/odo/pull/2027 won't pass without this :-D Chicken and Egg problem.

The less evil is to merge this first, as it won't break any existing code on odo side.

cdrage commented 5 years ago

I don't see any issue with this. Let's coordinate a time to merge all three in at the same time.

kadel commented 5 years ago

/lgtm

openshift-ci-robot commented 5 years ago

@kadel: you cannot LGTM your own PR.

In response to [this](https://github.com/openshift/odo-supervisord-image/pull/29#issuecomment-525702910): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.