add nodejs minishift images in language mapping

redhat-developer / odo-init-image

ODO v3 no loner users this image!!! (Container for ODO v2 to setup SupervisorD inside S2I builder image.)

Apache License 2.0

7 stars 27 forks source link

add nodejs minishift images in language mapping #36

Closed girishramnani closed 5 years ago

girishramnani commented 5 years ago

partly https://github.com/openshift/odo/issues/2129

mik-dass commented 5 years ago

•  Syncing files to the component  ...
[odo]  ✗  Syncing files to the component [125ms]
[odo]  ✗  unable to upgrade connection: container not found ("dotnet-app-app")

/retest

girishramnani commented 5 years ago

/retest

kadel commented 5 years ago

/approve

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/odo-init-image/blob/master/OWNERS)~~ [kadel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

dharmit commented 5 years ago

/lgtm