search

redhat-developer / odo-init-image

ODO v3 no loner users this image!!! (Container for ODO v2 to setup SupervisorD inside S2I builder image.)
Apache License 2.0
7 stars 27 forks source link

set JAVA_OPTIONS in java dev-run #38

Closed kadel closed 5 years ago

kadel commented 5 years ago

Older openjdk s2i images are using JAVA_OPTIONS instead of JAVA_OPTS

This PR makes sure that we set both variables, so it works on older images as well as on new one.

girishramnani commented 5 years ago

/approve

girishramnani commented 5 years ago

/lgtm

openshift-ci-robot commented 5 years ago

@girishramnani: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/odo-init-image/pull/38#issuecomment-534524057): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
girishramnani commented 5 years ago

/approve

girishramnani commented 5 years ago

/lgtm

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/odo-init-image/blob/master/OWNERS)~~ [girishramnani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment