search

redhat-developer / odo-init-image

ODO v3 no loner users this image!!! (Container for ODO v2 to setup SupervisorD inside S2I builder image.)
Apache License 2.0
7 stars 27 forks source link

Add more tests #56

Closed cdrage closed 4 years ago

cdrage commented 4 years ago

There were some tests that were missing in comparison to upstream tests.

This updates the tests (hopefully they all pass!)

It also re-organizes it (they were out of order) in comparison to upstream .travis.yml

Closes https://github.com/openshift/odo-init-image/issues/55

Signed-off-by: Charlie Drage charlie@charliedrage.com

cdrage commented 4 years ago

ping @girishramnani @kadel

girishramnani commented 4 years ago

/approve

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/odo-init-image/blob/master/OWNERS)~~ [girishramnani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kadel commented 4 years ago

/lgtm