search

redhat-developer / odo-init-image

ODO v3 no loner users this image!!! (Container for ODO v2 to setup SupervisorD inside S2I builder image.)
Apache License 2.0
7 stars 27 forks source link

Remove deprecated Nodejs images #64

Closed amitkrout closed 4 years ago

amitkrout commented 4 years ago

Follow up of - https://github.com/openshift/odo/pull/3414

ping @girishramnani

kadel commented 4 years ago

There needs to be a matching PR on odo cli https://github.com/openshift/odo/blob/9a470629475bf6339dec637ee5ea8e326188a7fd/pkg/catalog/catalog.go#L460

kadel commented 4 years ago

ping @amitkrout

amitkrout commented 4 years ago

There needs to be a matching PR on odo cli https://github.com/openshift/odo/blob/9a470629475bf6339dec637ee5ea8e326188a7fd/pkg/catalog/catalog.go#L460

Fixed via https://github.com/openshift/odo/pull/3587

girishramnani commented 4 years ago

Usually we push to a personal docker repo and use that in odo to confirm that tests pass. I hope u do that @amitkrout /approve

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/odo-init-image/blob/master/OWNERS)~~ [girishramnani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
amitkrout commented 4 years ago

Usually we push to a personal docker repo and use that in odo to confirm that tests pass. I hope u do that @amitkrout /approve

Travis script is handling this through https://github.com/openshift/odo-init-image/blob/master/scripts/build-push-image.sh

amitkrout commented 4 years ago

Usually we push to a personal docker repo and use that in odo to confirm that tests pass. I hope u do that @amitkrout /approve

Travis script is handling this through https://github.com/openshift/odo-init-image/blob/master/scripts/build-push-image.sh

Ahh.. its commented https://github.com/openshift/odo-init-image/blob/master/.travis.yml#L19 /hold

amitkrout commented 4 years ago

https://github.com/openshift/odo-init-image/pull/72#issuecomment-702735657 /close

openshift-ci-robot commented 4 years ago

@amitkrout: Closed this PR.

In response to [this](https://github.com/openshift/odo-init-image/pull/64#issuecomment-702735983): >https://github.com/openshift/odo-init-image/pull/72#issuecomment-702735657 >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.