search

redhat-developer / odo-init-image

ODO v3 no loner users this image!!! (Container for ODO v2 to setup SupervisorD inside S2I builder image.)
Apache License 2.0
7 stars 27 forks source link

[WIP] Make Supervisord conf path configurable #66

Closed adisky closed 4 years ago

adisky commented 4 years ago

since s2i and devfile uses different supervisord conf path. default is always the old value, to make migration easier It needs to be updated for https://github.com/openshift/odo/issues/3156

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign cdrage You can assign the PR to them by writing /assign @cdrage in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/odo-init-image/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
adisky commented 4 years ago

/retest

adisky commented 4 years ago

closing this, would open a new one /close

openshift-ci-robot commented 4 years ago

@adisky: Closed this PR.

In response to [this](https://github.com/openshift/odo-init-image/pull/66#issuecomment-662825140): >closing this, would open a new one >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.