search

redhat-developer / odo-init-image

ODO v3 no loner users this image!!! (Container for ODO v2 to setup SupervisorD inside S2I builder image.)
Apache License 2.0
7 stars 27 forks source link

Removing GOOS and GOARCH in preparation for multiarch builds #67

Closed mohammedzee1000 closed 4 years ago

mohammedzee1000 commented 4 years ago

Signed-off-by: Mohammed Zeeshan Ahmed mohammed.zee1000@gmail.com

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign cdrage You can assign the PR to them by writing /assign @cdrage in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/odo-init-image/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yselkowitz commented 4 years ago

/lgtm

openshift-ci-robot commented 4 years ago

@yselkowitz: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/odo-init-image/pull/67#issuecomment-652792917): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mohammedzee1000 commented 4 years ago

oc cluster up failure not related to pr changes. Image build successfully in local system. It is a minor change as well

cdrage commented 4 years ago

LGTM