redhat-developer / odo-init-image

ODO v3 no loner users this image!!! (Container for ODO v2 to setup SupervisorD inside S2I builder image.)
Apache License 2.0
7 stars 27 forks source link

Added ODO_S2I_CONVERTED_DEVFILE env variable #70

Closed adisky closed 4 years ago

adisky commented 4 years ago

To enable easy migration from s2i components to devfile, ODO_S2I_CONVERTED_DEVFILE environment variable is inserted to component while odo utils convert-to-devfile. There are some changes in script if this flag is enabled.

dharmit commented 4 years ago

/approve /lgtm

amitkrout commented 4 years ago

ping approvers - @kadel

kadel commented 4 years ago

/approve

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit, kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/odo-init-image/blob/master/OWNERS)~~ [kadel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment