search

redhat-developer / odo-init-image

ODO v3 no loner users this image!!! (Container for ODO v2 to setup SupervisorD inside S2I builder image.)
Apache License 2.0
7 stars 27 forks source link

Adding ubi8/nodejs-12 image as supported #72

Closed prietyc123 closed 3 years ago

prietyc123 commented 4 years ago

Adding ubi8/nodejs-12 image as supported because there is latest image difference between 4.5 and 4.6 cluster. More details are in issue https://github.com/openshift/odo/issues/4016 . There is also one pr on odo https://github.com/openshift/odo/pull/4070.

prietyc123 commented 4 years ago

ping @kadel

kadel commented 4 years ago

tests are failing. can you check why?

amitkrout commented 4 years ago

@prietyc123 Can you please include https://github.com/openshift/odo-init-image/pull/64 changes so that we can verify and push it in a single go. thanks

kadel commented 4 years ago

@amitkrout

@prietyc123 Can you please include #64 changes so that we can verify and push it in a single go. thanks

Why not continue in the original PR? This PR is addressing a different issue.

kadel commented 3 years ago

The test won't pass until https://github.com/openshift/odo/pull/4070 gets merged, https://github.com/openshift/odo/pull/4070 won't pass until this one is merged and a new init image is released.

The next steps:

/approve /lgtm /title Adding ubi8/nodejs-12 image as supported

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/odo-init-image/blob/master/OWNERS)~~ [kadel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment