search

redhat-developer / odo-init-image

ODO v3 no loner users this image!!! (Container for ODO v2 to setup SupervisorD inside S2I builder image.)
Apache License 2.0
7 stars 27 forks source link

Cosmetic changes (80 chars in a line) #89

Closed dharmit closed 2 years ago

dharmit commented 3 years ago

Some minor cosmetic changes that I found worth doing while going through the code:

  1. 80 characters in a single line because long comments/code become painful to comprehend
  2. s/Odo/odo at one place.
  3. s/exit/eixst at one place.
  4. Add double quotes around variable names
  5. Use -n instead of ! -z based on https://github.com/koalaman/shellcheck/wiki/SC2236 (auto suggested by GoLand)
openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign kadel after the PR has been reviewed. You can assign the PR to them by writing /assign @kadel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/odo-init-image/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dharmit commented 3 years ago

@kadel @mohammedzee1000 how to take PRs further on this repo in absence of Travis CI?

kadel commented 3 years ago

@kadel @mohammedzee1000 how to take PRs further on this repo in absence of Travis CI?

Probably question for @anandrkskd or @prietyc123

This was supposed to be addressed more than 7 months ago https://github.com/openshift/odo/issues/4315

If we don't have working automated tests you will have to test this manually.

openshift-bot commented 3 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 2 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-ci[bot] commented 2 years ago

@dharmit: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.