search

redhat-developer / odo

odo - Developer-focused CLI for fast & iterative container-based application development on Podman and Kubernetes. Implementation of the open Devfile standard.
https://odo.dev
Apache License 2.0
792 stars 244 forks source link

Support projects with dockerfile #2352

Open gorkem opened 5 years ago

gorkem commented 5 years ago

[kind/Feature]

Which functionality do you think we should add?

Allow projects that has a dockerfile to be taken into the inner-loop mode. User should be able to run a command such as odo create --image=<path/to/my/dockerfile. This is a different mode than our current s2i based mode. As a consequence we need a way to capture the commands to modify the contents of the image.

Why is this needed?

There are many container based applications that has a dockerfile and do not use s2i as their build. This will allow them to use odo to do their inner-loop without making major changes to do s2i based builds.

girishramnani commented 5 years ago

when using this feature, as we cannot know the variables like DEPLOYMENT_DIR etc that are present when s2i builder images are used and also we dont control the startup commands - Features like smarter push and debug wouldn't work.

Instead of smarter push either odo push --config could happen when only the config is changed or a rebuild could happen.

correct me if I am wrong @kadel

girishramnani commented 4 years ago

is this something we are still interested in @kadel @gorkem ?

kadel commented 4 years ago

is this something we are still interested in @kadel @gorkem ?

It might take a different form, but yes. This is something that we are still interested in

openshift-bot commented 4 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 4 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

kadel commented 4 years ago

/remove-lifecycle rotten /lifecycle frozen