search

redhat-developer / odo

odo - Developer-focused CLI for fast & iterative container-based application development on Podman and Kubernetes. Implementation of the open Devfile standard.
https://odo.dev
Apache License 2.0
792 stars 244 forks source link

Recognise `devfile.yml` and `.devfile.yml` as Devfiles #7060

Closed datho7561 closed 11 months ago

datho7561 commented 1 year ago

/kind bug

What versions of software are you using?

Operating System: Fedora Linux 38

Output of odo version:

odo v3.14.0 (471928fea)

Server: https://api.crc.testing:6443
Kubernetes: v1.26.6+73ac561
Podman Client: 4.6.1

How did you run odo exactly?

  1. Clone https://github.com/eclipse/lemminx.
  2. Add the recommended Devfile, which was the Maven one.
  3. Rename the Devfile to devfile.yml
  4. odo dev

Actual behavior

odo starts initializing a new component in interactive mode

Expected behavior

Dev mode starts, using devfile.yml as the Devfile.

Any logs, error output, etc?

See https://github.com/redhat-developer/vscode-openshift-tools/issues/3124

rm3l commented 1 year ago

/status blocked

Blocked on https://github.com/devfile/api/issues/1035, to clarify the acceptable filenames for devfile. https://github.com/devfile/api/issues/1035#issuecomment-1433139995 suggested supporting .yaml only, based on the YAML spec FAQ. Also related to https://github.com/devfile/api/issues/744. We'll need to confirm the decision on this..

rm3l commented 1 year ago

/remove-status blocked

Unblocked now that https://github.com/devfile/api/issues/1265 and https://github.com/devfile/api/issues/744 have been fixed on the Devfile parser library side. The changes in the Devfile library have been pulled in https://github.com/redhat-developer/odo/pull/7130.