search

redhat-developer / odo

odo - Developer-focused CLI for fast & iterative container-based application development on Podman and Kubernetes. Implementation of the open Devfile standard.
https://odo.dev
Apache License 2.0
777 stars 242 forks source link

[UI] Make sure form validation displays non-valid fields as red in all forms #7064

Closed rm3l closed 10 months ago

rm3l commented 11 months ago

What type of PR is this: /area Web-UI

What does this PR do / why we need it: This makes sure invalid fields are highlighted as red in all forms.

Add an Exec Command ![image](https://github.com/redhat-developer/odo/assets/593208/97295776-c1d2-4be2-82f0-b922b3627ec3)
Add an Image Command ![image](https://github.com/redhat-developer/odo/assets/593208/cf511133-dff8-4696-94a5-7c1389399de7)
Add an Apply Command ![image](https://github.com/redhat-developer/odo/assets/593208/d3dba09d-8f56-45c0-962f-266333d4d0ed)
Add a Composite Command ![image](https://github.com/redhat-developer/odo/assets/593208/2b6ca841-d3b0-4ef9-9e6d-c8a6ad95f7c6)
Add a new container ![image](https://github.com/redhat-developer/odo/assets/593208/d33c2cae-c004-4bf3-b058-de03cde2fd1b) ![image](https://github.com/redhat-developer/odo/assets/593208/ccf5d101-3f34-4f54-b85a-a61d72bc6d04)
Add a new image ![image](https://github.com/redhat-developer/odo/assets/593208/b7916889-7212-47b2-8ecd-46dc4b7e30f3)
Add a new resource ![image](https://github.com/redhat-developer/odo/assets/593208/edf81d2d-eea3-4aff-b0df-0180fee3a4c4)
Add a new volume ![image](https://github.com/redhat-developer/odo/assets/593208/28f02cf3-5c79-4d3d-9519-6385c9a0c181)

Which issue(s) this PR fixes: Fixes #7054

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

netlify[bot] commented 11 months ago

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
Latest commit 7055b6e2c7bb6f47aa04e94ea93680e96dcdca22
Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64f71aaa40cf3d0008a1f9af
openshift-ci[bot] commented 11 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

odo-robot[bot] commented 11 months ago

OpenShift Unauthenticated Tests on commit 00cd2e5b81023d14375d9a3ede4a16342414a1dd finished successfully. View logs: TXT HTML

odo-robot[bot] commented 11 months ago

NoCluster Tests on commit 00cd2e5b81023d14375d9a3ede4a16342414a1dd finished successfully. View logs: TXT HTML

odo-robot[bot] commented 11 months ago

Unit Tests on commit 00cd2e5b81023d14375d9a3ede4a16342414a1dd finished successfully. View logs: TXT HTML

odo-robot[bot] commented 11 months ago

Validate Tests on commit 00cd2e5b81023d14375d9a3ede4a16342414a1dd finished successfully. View logs: TXT HTML

odo-robot[bot] commented 11 months ago

Kubernetes Tests on commit 00cd2e5b81023d14375d9a3ede4a16342414a1dd finished with errors. View logs: TXT HTML

odo-robot[bot] commented 11 months ago

Windows Tests (OCP) on commit 00cd2e5b81023d14375d9a3ede4a16342414a1dd finished with errors. View logs: TXT HTML

odo-robot[bot] commented 11 months ago

OpenShift Tests on commit 00cd2e5b81023d14375d9a3ede4a16342414a1dd finished with errors. View logs: TXT HTML

odo-robot[bot] commented 11 months ago

Kubernetes Docs Tests on commit a65812143c0338c2be04d87f1d729ea8611161d0 finished successfully. View logs: TXT HTML

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

rm3l commented 10 months ago 
  [FAILED] in [It] - /go/odo_1/tests/helper/helper_cmd_wrapper.go:120 @ 09/05/23 12:54:55.574
  Running kubectl with args [kubectl get namespace cmd-devfile-deploy-test695stb -o jsonpath={.metadata.name}] and odo env: []
  [kubectl] cmd-devfile-deploy-test695stbDeleting project: cmd-devfile-deploy-test695stb
  Running kubectl with args [kubectl delete namespaces cmd-devfile-deploy-test695stb --wait=false] and odo env: []
  [kubectl] namespace "cmd-devfile-deploy-test695stb" deleted
  Setting current dir to: /go/odo_1/tests/integration
  Deleting dir: /tmp/3472070801
  Deleting dir: /tmp/2108200904
  << Timeline

  [FAILED] Timed out after 600.000s.
  Expected process to exit.  It did not.
  In [It] at: /go/odo_1/tests/helper/helper_cmd_wrapper.go:120 @ 09/05/23 12:54:55.574
...
Summarizing 1 Failure:
  [FAIL] odo devfile deploy command tests deploying devfile with long-running exec when Automount volumes are present in the namespace [It] should mount the volumes
  /go/odo_1/tests/helper/helper_cmd_wrapper.go:120

Ran 409 of 954 Specs in 1327.923 seconds
FAIL! -- 408 Passed | 1 Failed | 0 Pending | 545 Skipped

UI-only PR, so not related to the failures here.

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

openshift-ci[bot] commented 10 months ago

@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

In response to [this](https://github.com/redhat-developer/odo/pull/7064#issuecomment-1706804612): >``` > [FAILED] in [It] - /go/odo_1/tests/helper/helper_cmd_wrapper.go:120 @ 09/05/23 12:54:55.574 > Running kubectl with args [kubectl get namespace cmd-devfile-deploy-test695stb -o jsonpath={.metadata.name}] and odo env: [] > [kubectl] cmd-devfile-deploy-test695stbDeleting project: cmd-devfile-deploy-test695stb > Running kubectl with args [kubectl delete namespaces cmd-devfile-deploy-test695stb --wait=false] and odo env: [] > [kubectl] namespace "cmd-devfile-deploy-test695stb" deleted > Setting current dir to: /go/odo_1/tests/integration > Deleting dir: /tmp/3472070801 > Deleting dir: /tmp/2108200904 > << Timeline > > [FAILED] Timed out after 600.000s. > Expected process to exit. It did not. > In [It] at: /go/odo_1/tests/helper/helper_cmd_wrapper.go:120 @ 09/05/23 12:54:55.574 >... >Summarizing 1 Failure: > [FAIL] odo devfile deploy command tests deploying devfile with long-running exec when Automount volumes are present in the namespace [It] should mount the volumes > /go/odo_1/tests/helper/helper_cmd_wrapper.go:120 > >Ran 409 of 954 Specs in 1327.923 seconds >FAIL! -- 408 Passed | 1 Failed | 0 Pending | 545 Skipped >``` > >UI-only PR, so not related to the failures here. > >/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rm3l commented 10 months ago 
       âš   0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
       âš   Pod is Pending
       âš   0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
       âš   AttachVolume.Attach failed for volume "pvc-1606fb7f-4869-4b2a-b0d5-9fd061018b19" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-ead57323-f582-4fee-a68b-c7fcbd5c5092
       âš   AttachVolume.Attach failed for volume "pvc-8521c60b-5aa0-433d-86dc-8bc09d2ba498" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-cafd8507-9798-4a46-8a0f-440ba39d1c04
       âš   Unable to attach or mount volumes: unmounted volumes=[firstvol-jwjpal-app-vol secondvol-jwjpal-app-vol], unattached volumes=[odo-shared-data firstvol-jwjpal-app-vol secondvol-jwjpal-app-vol kube-api-access-xtxx6 odo-projects]: timed out waiting for the condition

...
Summarizing 3 Failures:
  [FAIL] odo devfile deploy command tests deploying devfile with long-running exec when Automount volumes are present in the namespace [It] should mount the volumes
  /go/odo_1/tests/helper/helper_cmd_wrapper.go:120
  [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components
  /go/odo_1/tests/helper/helper_run.go:54
  [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - with metadata.name [BeforeEach] should successfully use the volume components in container components
  /go/odo_1/tests/helper/helper_run.go:54

Ran 404 of 954 Specs in 1598.498 seconds
FAIL! -- 401 Passed | 3 Failed | 0 Pending | 550 Skipped

Looks like there are some issues with volumes. Let's keep an eye out for those failures to see if they happen again. Overriding because this is a UI-only PR, so not related to the failures here.

/override OpenShift-Integration-tests/OpenShift-Integration-tests

openshift-ci[bot] commented 10 months ago

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to [this](https://github.com/redhat-developer/odo/pull/7064#issuecomment-1706808178): >``` > âš 0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling. > âš Pod is Pending > âš 0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling. > âš AttachVolume.Attach failed for volume "pvc-1606fb7f-4869-4b2a-b0d5-9fd061018b19" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-ead57323-f582-4fee-a68b-c7fcbd5c5092 > âš AttachVolume.Attach failed for volume "pvc-8521c60b-5aa0-433d-86dc-8bc09d2ba498" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-cafd8507-9798-4a46-8a0f-440ba39d1c04 > âš Unable to attach or mount volumes: unmounted volumes=[firstvol-jwjpal-app-vol secondvol-jwjpal-app-vol], unattached volumes=[odo-shared-data firstvol-jwjpal-app-vol secondvol-jwjpal-app-vol kube-api-access-xtxx6 odo-projects]: timed out waiting for the condition > >... >Summarizing 3 Failures: > [FAIL] odo devfile deploy command tests deploying devfile with long-running exec when Automount volumes are present in the namespace [It] should mount the volumes > /go/odo_1/tests/helper/helper_cmd_wrapper.go:120 > [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components > /go/odo_1/tests/helper/helper_run.go:54 > [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - with metadata.name [BeforeEach] should successfully use the volume components in container components > /go/odo_1/tests/helper/helper_run.go:54 > >Ran 404 of 954 Specs in 1598.498 seconds >FAIL! -- 401 Passed | 3 Failed | 0 Pending | 550 Skipped >``` > >Looks like there are some issues with volumes. Let's keep an eye out for those failures to see if they happen again. >Overriding because this is a UI-only PR, so not related to the failures here. > >/override OpenShift-Integration-tests/OpenShift-Integration-tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rm3l commented 10 months ago 

  [FAILED] Timed out after 420.012s.
  Expected
      <string>:   __
       /  \__     Developing using the "wmrbzj" Devfile
       \__/  \    Namespace: cmd-dev-test577yhx
       /  \__/    odo version: v3.14.0
       \__/

      - Running on the cluster in Dev mode
       -  Waiting for Kubernetes resources  ...
       !  Pod is Pending
       !  0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
       !  0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
       !  AttachVolume.Attach failed for volume "pvc-0e9d83df-b6c5-479c-b131-bbe589324d8a" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-75cd0332-23ad-484f-b11d-7c4827c29cf6
       !  Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-projects odo-shared-data kube-api-access-mphwf]: timed out waiting for the condition

  to contain substring
      <string>: [Ctrl+c] - Exit
  In [BeforeEach] at: C:/Users/Administrator.ANSIBLE-TEST-VS/4557/tests/helper/helper_run.go:54 @ 09/05/23 07:54:40.296
[...]

Summarizing 5 Failures:
  [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] should have created resources
  C:/Users/Administrator.ANSIBLE-TEST-VS/4557/tests/helper/helper_run.go:54
  [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when stopping odo dev normally should have deleted all resources before returning
  C:/Users/Administrator.ANSIBLE-TEST-VS/4557/tests/helper/helper_run.go:54
  [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when killing odo dev and running odo delete component --wait should have deleted all resources before returning
  C:/Users/Administrator.ANSIBLE-TEST-VS/4557/tests/helper/helper_run.go:54
  [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - with metadata.name [BeforeEach] should successfully use the volume components in container components
  C:/Users/Administrator.ANSIBLE-TEST-VS/4557/tests/helper/helper_run.go:54
  [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components
  C:/Users/Administrator.ANSIBLE-TEST-VS/4557/tests/helper/helper_run.go:54

Ran 388 of 954 Specs in 1476.036 seconds
FAIL! -- 383 Passed | 5 Failed | 0 Pending | 566 Skipped

Looks like there are some issues with volumes. Let's keep an eye out for those failures to see if they happen again. Overriding because this is a UI-only PR, so not related to the failures here.

/override windows-integration-test/Windows-test

openshift-ci[bot] commented 10 months ago

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

In response to [this](https://github.com/redhat-developer/odo/pull/7064#issuecomment-1706810291): >``` > > [FAILED] Timed out after 420.012s. > Expected > : __ > / \__ Developing using the "wmrbzj" Devfile > \__/ \ Namespace: cmd-dev-test577yhx > / \__/ odo version: v3.14.0 > \__/ > > - Running on the cluster in Dev mode > - Waiting for Kubernetes resources ... > ! Pod is Pending > ! 0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling. > ! 0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling. > ! AttachVolume.Attach failed for volume "pvc-0e9d83df-b6c5-479c-b131-bbe589324d8a" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-75cd0332-23ad-484f-b11d-7c4827c29cf6 > ! Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-projects odo-shared-data kube-api-access-mphwf]: timed out waiting for the condition > > to contain substring > : [Ctrl+c] - Exit > In [BeforeEach] at: C:/Users/Administrator.ANSIBLE-TEST-VS/4557/tests/helper/helper_run.go:54 @ 09/05/23 07:54:40.296 >[...] > >Summarizing 5 Failures: > [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] should have created resources > C:/Users/Administrator.ANSIBLE-TEST-VS/4557/tests/helper/helper_run.go:54 > [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when stopping odo dev normally should have deleted all resources before returning > C:/Users/Administrator.ANSIBLE-TEST-VS/4557/tests/helper/helper_run.go:54 > [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when killing odo dev and running odo delete component --wait should have deleted all resources before returning > C:/Users/Administrator.ANSIBLE-TEST-VS/4557/tests/helper/helper_run.go:54 > [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - with metadata.name [BeforeEach] should successfully use the volume components in container components > C:/Users/Administrator.ANSIBLE-TEST-VS/4557/tests/helper/helper_run.go:54 > [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components > C:/Users/Administrator.ANSIBLE-TEST-VS/4557/tests/helper/helper_run.go:54 > >Ran 388 of 954 Specs in 1476.036 seconds >FAIL! -- 383 Passed | 5 Failed | 0 Pending | 566 Skipped >``` > >Looks like there are some issues with volumes. Let's keep an eye out for those failures to see if they happen again. >Overriding because this is a UI-only PR, so not related to the failures here. > >/override windows-integration-test/Windows-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.