redhat-developer / odo

odo - Developer-focused CLI for fast & iterative container-based application development on Podman and Kubernetes. Implementation of the open Devfile standard.
https://odo.dev
Apache License 2.0
777 stars 242 forks source link

Warning if version of Devfile is different from 2.2.0 #7065

Closed feloy closed 10 months ago

feloy commented 11 months ago

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #7048

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

netlify[bot] commented 11 months ago

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
Latest commit 4465778c252a7124fbe112db08a21ddb5131e98a
Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64f6cf27daca7c000848ea84
odo-robot[bot] commented 11 months ago

NoCluster Tests on commit bee208dfd17b9c53a8249b7cce61f91ffae50c7f finished successfully. View logs: TXT HTML

odo-robot[bot] commented 11 months ago

OpenShift Unauthenticated Tests on commit bee208dfd17b9c53a8249b7cce61f91ffae50c7f finished successfully. View logs: TXT HTML

odo-robot[bot] commented 11 months ago

Unit Tests on commit bee208dfd17b9c53a8249b7cce61f91ffae50c7f finished successfully. View logs: TXT HTML

odo-robot[bot] commented 11 months ago

Validate Tests on commit bee208dfd17b9c53a8249b7cce61f91ffae50c7f finished successfully. View logs: TXT HTML

odo-robot[bot] commented 11 months ago

Kubernetes Tests on commit bee208dfd17b9c53a8249b7cce61f91ffae50c7f finished successfully. View logs: TXT HTML

odo-robot[bot] commented 11 months ago

Windows Tests (OCP) on commit bee208dfd17b9c53a8249b7cce61f91ffae50c7f finished successfully. View logs: TXT HTML

odo-robot[bot] commented 11 months ago

Kubernetes Docs Tests on commit e21b80f72ab68eb06efc5a436c97c560b8215992 finished successfully. View logs: TXT HTML

odo-robot[bot] commented 11 months ago

OpenShift Tests on commit bee208dfd17b9c53a8249b7cce61f91ffae50c7f finished successfully. View logs: TXT HTML

feloy commented 10 months ago

When the schema version is changed from 2.1.0 to 2.2.0 from the YAML view and then persisted to the filesystem, the snackbar notification was still present.

Screencast.from.2023-09-04.11-17-21.webm Do you think it would be possible to dismiss it if the schema version is the expected one?

No, I don't think it would help that much. It is not a status bar, just a warning at some point in time.

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication