redhat-developer / odo

odo - Developer-focused CLI for fast & iterative container-based application development on Podman and Kubernetes. Implementation of the open Devfile standard.
https://odo.dev
Apache License 2.0
777 stars 242 forks source link

[UI] Allow single item deletion from multi-value fields #7084

Closed rm3l closed 10 months ago

rm3l commented 10 months ago

What type of PR is this: /kind feature /area Web-UI

What does this PR do / why we need it:

This adds the ability in the odo dev UI to delete single items from multi-value fields:

Screenshots ![image](https://github.com/redhat-developer/odo/assets/593208/0f8fa0ca-e5b9-4600-9dd4-087f32690f53) ![image](https://github.com/redhat-developer/odo/assets/593208/75fe550b-4452-40ab-be09-f88fe6c5bc47) ![image](https://github.com/redhat-developer/odo/assets/593208/d9eae7f4-7197-476b-9308-744228d1145b)

Which issue(s) this PR fixes: Fixes #7055

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

openshift-ci[bot] commented 10 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

netlify[bot] commented 10 months ago

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
Latest commit b0412b0eeeb26174bd789af9612c4f34c97df6af
Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6504800ef0f346000899efa1
odo-robot[bot] commented 10 months ago

Kubernetes Docs Tests on commit b20ceb619c751e940ffb47a03e88e0ce088940ed finished successfully. View logs: TXT HTML

odo-robot[bot] commented 10 months ago

Windows Tests (OCP) on commit 83ea48039602fce0d6d2bf04869c77db0d1cf748 finished successfully. View logs: TXT HTML

odo-robot[bot] commented 10 months ago

OpenShift Unauthenticated Tests on commit 83ea48039602fce0d6d2bf04869c77db0d1cf748 finished successfully. View logs: TXT HTML

odo-robot[bot] commented 10 months ago

NoCluster Tests on commit 83ea48039602fce0d6d2bf04869c77db0d1cf748 finished successfully. View logs: TXT HTML

odo-robot[bot] commented 10 months ago

Unit Tests on commit 83ea48039602fce0d6d2bf04869c77db0d1cf748 finished successfully. View logs: TXT HTML

odo-robot[bot] commented 10 months ago

Validate Tests on commit 83ea48039602fce0d6d2bf04869c77db0d1cf748 finished successfully. View logs: TXT HTML

odo-robot[bot] commented 10 months ago

Kubernetes Tests on commit 83ea48039602fce0d6d2bf04869c77db0d1cf748 finished successfully. View logs: TXT HTML

odo-robot[bot] commented 10 months ago

OpenShift Tests on commit 83ea48039602fce0d6d2bf04869c77db0d1cf748 finished with errors. View logs: TXT HTML

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

rm3l commented 10 months ago
  [FAILED] Expected
      <string>:   __
       /  \__     Developing using the "lwvxbb" Devfile
       \__/  \    Namespace: cmd-logs-test249kbi
       /  \__/    odo version: v3.14.0 (b0412b0ee)
       \__/

      ↪ Running on the cluster in Dev mode
       •  Waiting for Kubernetes resources  ...
       âš   Pod is Pending
       ✓  Pod is Running
      --> Logs for lwvxbb-app-845986b854-nl689 / runtime
       •  Syncing files into the container  ...

 ✓  Syncing files into the container [457ms]
       •  Building your application in container (command: install)  ...
      runtime: npm notice created a lockfile as package-lock.json. You should commit this file.
      runtime: npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.3.2 (node_modules/chokidar/node_modules/fsevents):
      runtime: npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.3.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
      runtime: npm WARN node-echo@0.0.1 No repository field.
      runtime: npm WARN node-echo@0.0.1 No license field.
      runtime: 
      runtime: added 33 packages from 29 contributors and audited 34 packages in 1.481s
      runtime: 
      runtime: 3 packages are looking for funding
      runtime:   run `npm fund` for details
      runtime: 
      runtime: found 0 vulnerabilities
      runtime: 

 ✓  Building your application in container (command: install) [2s]

      ↪ Deploying Kubernetes Component: myapp-inner
       •  Creating resource Pod/myapp-inner  ...

 ✓  Creating resource Pod/myapp-inner 
       •  Executing the application (command: start)  ...
      runtime: 
      runtime: > node-echo@0.0.1 start /projects
      runtime: > node server.js
      runtime: 
      runtime: Server running on 0.0.0.0:8080
       •  Waiting for the application to be ready  ...

 ✓  Waiting for the application to be ready [1s]
       -  Forwarding from 127.0.0.1:34059 -> 8080

      ↪ Dev mode
       Status:
       Watching for changes in the current directory /tmp/2912389663

      Keyboard Commands:
      [Ctrl+c] - Exit and delete resources from the cluster
           [p] - Manually apply local changes to the application on the cluster

  to contain substring
      <string>: main: 

[...]
Summarizing 1 Failure:
  [FAIL] odo logs command tests when component is created and odo logs is executed when running in Dev mode with --logs [It] 1. should successfully show logs of the running component
  /go/odo_1/tests/integration/cmd_logs_test.go:253

Ran 404 of 954 Specs in 1409.505 seconds
FAIL! -- 403 Passed | 1 Failed | 0 Pending | 550 Skipped

Flaky issue with odo logs - reported in #6619 (will reopen if the issue persists on other PRs)..

/override OpenShift-Integration-tests/OpenShift-Integration-tests

openshift-ci[bot] commented 10 months ago

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to [this](https://github.com/redhat-developer/odo/pull/7084#issuecomment-1722942511): >``` > [FAILED] Expected > : __ > / \__ Developing using the "lwvxbb" Devfile > \__/ \ Namespace: cmd-logs-test249kbi > / \__/ odo version: v3.14.0 (b0412b0ee) > \__/ > > ↪ Running on the cluster in Dev mode > • Waiting for Kubernetes resources ... > ⚠Pod is Pending > ✓ Pod is Running > --> Logs for lwvxbb-app-845986b854-nl689 / runtime > • Syncing files into the container ... > > ✓ Syncing files into the container [457ms] > • Building your application in container (command: install) ... > runtime: npm notice created a lockfile as package-lock.json. You should commit this file. > runtime: npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.3.2 (node_modules/chokidar/node_modules/fsevents): > runtime: npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.3.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"}) > runtime: npm WARN node-echo@0.0.1 No repository field. > runtime: npm WARN node-echo@0.0.1 No license field. > runtime: > runtime: added 33 packages from 29 contributors and audited 34 packages in 1.481s > runtime: > runtime: 3 packages are looking for funding > runtime: run `npm fund` for details > runtime: > runtime: found 0 vulnerabilities > runtime: > > ✓ Building your application in container (command: install) [2s] > > ↪ Deploying Kubernetes Component: myapp-inner > • Creating resource Pod/myapp-inner ... > > ✓ Creating resource Pod/myapp-inner > • Executing the application (command: start) ... > runtime: > runtime: > node-echo@0.0.1 start /projects > runtime: > node server.js > runtime: > runtime: Server running on 0.0.0.0:8080 > • Waiting for the application to be ready ... > > ✓ Waiting for the application to be ready [1s] > - Forwarding from 127.0.0.1:34059 -> 8080 > > > ↪ Dev mode > Status: > Watching for changes in the current directory /tmp/2912389663 > > Keyboard Commands: > [Ctrl+c] - Exit and delete resources from the cluster > [p] - Manually apply local changes to the application on the cluster > > to contain substring > : main: > >[...] >Summarizing 1 Failure: > [FAIL] odo logs command tests when component is created and odo logs is executed when running in Dev mode with --logs [It] 1. should successfully show logs of the running component > /go/odo_1/tests/integration/cmd_logs_test.go:253 > >Ran 404 of 954 Specs in 1409.505 seconds >FAIL! -- 403 Passed | 1 Failed | 0 Pending | 550 Skipped >``` > >Flaky issue with `odo logs` - reported in #6619 (will reopen if the issue persists on other PRs).. > >/override OpenShift-Integration-tests/OpenShift-Integration-tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.