redhat-developer / odo

odo - Developer-focused CLI for fast & iterative container-based application development on Podman and Kubernetes. Implementation of the open Devfile standard.
https://odo.dev
Apache License 2.0
777 stars 242 forks source link

Make sure a Deploy command is present in the Devfile before auto-applying components #7093

Closed rm3l closed 10 months ago

rm3l commented 10 months ago

What type of PR is this: /kind bug /area deploy

What does this PR do / why we need it: When the Devfile does not have any deploy command but contains some components that are auto-applied (e.g., with autoBuild or deployByDefault set to true), odo deploy will try to apply them before ending up complaining that it could not find any deploy command. This PR makes sure to check this before applying anything. See #6743 for more context.

Which issue(s) this PR fixes: Fixes #6743

PR acceptance criteria:

How to test changes / Special notes to the reviewer: See #6743 for the repro steps.

netlify[bot] commented 10 months ago

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
Latest commit d57d1a1e0971f8f963cde752572ebdcf44d3e269
Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/650ad496e14dc30008861c84
odo-robot[bot] commented 10 months ago

OpenShift Unauthenticated Tests on commit c5462a523b44091eb44ca8f5736c0865c7fa00bb finished successfully. View logs: TXT HTML

odo-robot[bot] commented 10 months ago

NoCluster Tests on commit c5462a523b44091eb44ca8f5736c0865c7fa00bb finished successfully. View logs: TXT HTML

odo-robot[bot] commented 10 months ago

Unit Tests on commit c5462a523b44091eb44ca8f5736c0865c7fa00bb finished successfully. View logs: TXT HTML

odo-robot[bot] commented 10 months ago

Validate Tests on commit c5462a523b44091eb44ca8f5736c0865c7fa00bb finished successfully. View logs: TXT HTML

odo-robot[bot] commented 10 months ago

Kubernetes Tests on commit c5462a523b44091eb44ca8f5736c0865c7fa00bb finished successfully. View logs: TXT HTML

odo-robot[bot] commented 10 months ago

Windows Tests (OCP) on commit c5462a523b44091eb44ca8f5736c0865c7fa00bb finished successfully. View logs: TXT HTML

odo-robot[bot] commented 10 months ago

OpenShift Tests on commit c5462a523b44091eb44ca8f5736c0865c7fa00bb finished successfully. View logs: TXT HTML

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

odo-robot[bot] commented 10 months ago

Kubernetes Docs Tests on commit 9e1698bc990ce9916ae4447f2a276309fb20bf8c finished successfully. View logs: TXT HTML