search

redhat-developer / odo

odo - Developer-focused CLI for fast & iterative container-based application development on Podman and Kubernetes. Implementation of the open Devfile standard.
https://odo.dev
Apache License 2.0
788 stars 243 forks source link

Odo panics when overriding parent:components:attributes:pod-overrides:spec:imagePullSecrets:name #7099

Open AgentK9 opened 1 year ago

AgentK9 commented 1 year ago

/kind bug

What versions of software are you using?

Operating System: N/A (reproduced on windows and MacOS, but independent of OS or k8s back end)

Output of odo version: v3.14.0

How did you run odo exactly?

brew install odo, odo dev.

This may be an issue with the devfile library, unsure.

Actual behavior

See here for error message

Expected behavior

No error. odo dev runs as expected

Any logs, error output, etc?

See POC repo here

rm3l commented 1 year ago

Hi @AgentK9!

Thanks for reporting the issue and providing a sample repro repo. FYI, the attribute for overriding properties of the pod spec is pod-overrides, not pod-override. Anyway, even with that, the issue was still there. From the stacktrace, it looks like an issue with how the Devfile library merges complex attributes when handling a parent-child relationship. I'll report this to the Devfile library repo, and when it is fixed there, we'll need to update odo accordingly.

/status blocked EDIT: Blocked by https://github.com/devfile/api/issues/1268

AgentK9 commented 1 year ago

Awesome! Thanks for the quick response. Edited the title to reflect your comment. Hope this gets resolved soon!

github-actions[bot] commented 9 months ago

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

github-actions[bot] commented 8 months ago

This issue was closed because it has been inactive for 30 days since being marked as stale.

AgentK9 commented 8 months ago

Still an issue!

rm3l commented 8 months ago

Still an issue!

Reopening, but still blocked by https://github.com/devfile/api/issues/1268

/reopen /remove-lifecycle stale /remove-lifecycle rotten

openshift-ci[bot] commented 8 months ago

@rm3l: Reopened this issue.

In response to [this](https://github.com/redhat-developer/odo/issues/7099#issuecomment-1923833005): >> Still an issue! > >Reopening, but still blocked by https://github.com/devfile/api/issues/1268 > >/reopen >/remove-lifecycle stale >/remove-lifecycle rotten Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.