search

redhat-developer / opencompose

OpenCompose - A higher level abstraction for Kubernetes Resource
Apache License 2.0
64 stars 12 forks source link

feat(spec): add support for health #143

Closed surajssd closed 7 years ago

surajssd commented 7 years ago

Add support for providing things like livenessProbe and readinessProbe. Add a new field in container level called health which has readinessProbe and livenessProbe. These fields are identical to the way we define livenessProbe or readinessProbe in kubernetes. So no new extra field has been added, everything that k8s supports works with the health option in OpenCompose.

fixes #24

surajssd commented 7 years ago

@kadel @containscafeine PTAL at code need some help with adding docs, though, should I refer to the upstream docs directly or add all the fields in our doc?

kadel commented 7 years ago

containscafeine self-requested a review 9 minutes ago

:rofl:

kadel commented 7 years ago

@kadel @containscafeine PTAL at code need some help with adding docs, though, should I refer to the upstream docs directly or add all the fields in our doc?

i would add it into our doc, I think it would be better to have everything in one single doc.

surajssd commented 7 years ago

Closing since the project is now discontinued!