Enable build on RHEL - Githubissues

redhat-developer / osd-monitor-poc

8 stars 20 forks source link

Enable build on RHEL #28

Closed riuvshin closed 6 years ago

riuvshin commented 6 years ago

Enable build on RHEL if TARGET=rhel.

The cico environment will continue to build the CentOS based container and in a second step it will build and push a RHEL based container. As of now, the CentOS containers will be the ones being deployed to prod-preview and prod.

cc: @fche

fche commented 6 years ago

There's no way to parametrize the Dockerfile itself for the base image, so we don't have to 99.5%-duplicate them for centos vs rhel?

riuvshin commented 6 years ago

@fche actually, there is a way to doit this way:

ARG BASE_IMAGE=alpine
ARG BASE_TAG=3.4
FROM $BASE_IMAGE:$BASE_TAG

and then using docker build --build-arg BASE_IMAGE=busybox --build-arg BASE_TAG=latest override defaults, but that was added in very recent docker daemon which is not available for RHEL yet... anyway @kbsingh decided to keep rhel docker files separately at least for now.

jmelis commented 6 years ago

That is a v17 feature, not available in our v12.

fche commented 6 years ago

Are we expecting ci.centos.org to use the 'rhel' variant toward osio stage (rh-idev) now? I'm seeing the brand new images still being based on centos.

jmelis commented 6 years ago

@fche, not enabled yet, we will soon send a PR to change the base images for the pods defined here: https://github.com/redhat-developer/osd-monitor-poc/blob/master/osd-monitor.yml#L29

Once that is changed saasherder will deploy the RHEL based containers