search

redhat-developer / podman-desktop-redhat-account-ext

Podman Desktop Red Hat Account Extension
Apache License 2.0
3 stars 9 forks source link

Extension should not register sign in requests or run any subscription related commands #152

Open dgolovin opened 4 months ago

dgolovin commented 4 months ago

In latest release the Red Hat SSO extension itself adds so called Authentication request which is visible on:

  1. Authentication settings page
  2. Buddy Icon context menu in activity bar
  3. Status bar as a hat

When one uses any of the mentioned controls the ext redirects to the default browser for authentication and after successful login 1. Creates registry.redhat.com account in Registries settings

  1. Activates developer subscription in current active podman VM

That was done to simplify implementation and user experience for summit. With no dependent extension published that works just fine. But when OpenShift Local extension start using Red Hat SSO extension to let user to pull pull-secret without copy paste commands that executed after sign in look a bit out of context. Same can be told about developer sandbox connection configuration, when extension needs the SSO token to talk to sandbox registration service and has nothing to do with building Bootable Images based on RHEL.

Considering above problems the SSO Extension should not:

  1. Add authentication request
  2. Assume registry access configuration is required
  3. Or subscription activation is required

All three item should be delegated to dependent extensions because SSO extension is not aware of the reason for authentication request.

Related issues:

jeffmaury commented 3 weeks ago

As per discussion with @slemeur this is not a priority, we can keep Podman Machine as a requirement, so moving to Postponed