redhat-developer / podman-desktop-redhat-account-ext

Podman Desktop Red Hat Account Extension
Apache License 2.0
3 stars 9 forks source link

redirecting to Podman Desktop requires prompt #92

Open vrothberg opened 7 months ago

vrothberg commented 7 months ago

Any chance we can get rid of the prompt below? It's adding one click and gets in the user's way.

Cc: @benoitf @dgolovin @slemeur

Screenshot 2024-04-03 at 09 02 47

benoitf commented 7 months ago

we can't it's the browser that triggers that

benoitf commented 7 months ago

so, here, I think the key would be to not use the podman-desktop URI (dead end as it's managed by the Browser)

But, as we're browsing the content of the page provided by the extension and if we're here it's because Podman Desktop is already running

so the pattern should be:

if I click on a button, notify backend side of the extension that I need to go back to Podman Desktop

then, the extension should call something to Podman Desktop core to bring back the window (focus / steal)

I think the issue can be reopened but the flow needs to be changed (as the way it is currently implemented it won't be possible)

benoitf commented 7 months ago

@vrothberg I'm confused, you closed the issue but it means we still have that popup while we could improve it not have it.

vrothberg commented 7 months ago

Apologies! I must have missed that you reopened and just clicked on the button without reading.

benoitf commented 7 months ago

no problem, just wanted to confirm

dgolovin commented 4 months ago

Implementation ideas for activating PD window https://github.com/electron/electron/issues/2867