angelozerr
commented
2 years ago I understand the problem and I think PropertiesHoverParticipant should be customizable by adding a new parameter in the constructor Function<String, String> propertyReplacer and use it in https://github.com/eclipse/lsp4mp/blob/master/microprofile.jdt/org.eclipse.lsp4mp.jdt.core/src/main/java/org/eclipse/lsp4mp/jdt/core/java/hover/PropertiesHoverParticipant.java#L161
We should have a default replacer which return the property key.
- in ConfigProperty, default replacer will be used
- in Scheduler the replacer will manage ${} and {}.
rgrunber
In the
@Scheduledannotation,cron = {cron.expr}will refer to a referenced propertycron.expr. Hovering over it will confirm this. However,${cron.expr}is also a valid syntax, but hovering over it does not produce anything.The issue is due to https://github.com/eclipse/lsp4mp/blob/master/microprofile.jdt/org.eclipse.lsp4mp.jdt.core/src/main/java/org/eclipse/lsp4mp/jdt/core/java/hover/PropertiesHoverParticipant.java#L161 not handling
$.This also has an odd side effect. Take any
namemember of@ConfigProperty, and reference a valid property as follows :@ConfigProperty(name="{greeting.message}. An warning will show to indicate that the value doesn't exist, yet the hover will referencegreeting.messagein the configuration file!Are we ok with this ? It looks like to avoid this we would have to move the logic that accepts the curly brace/dollar somewhere else, and potentially enable/disable it based on the annotation/member On the other hand, this might be a nice side effect also.