search

redhat-developer / quarkus-ls

Language server for Quarkus tooling
Eclipse Public License 2.0
43 stars 15 forks source link

Definition for user tag parameter #790

Closed angelozerr closed 1 year ago

angelozerr commented 1 year ago

Definition for user tag parameter

Fixes #789

Signed-off-by: azerr azerr@redhat.com

angelozerr commented 1 year ago

Here a demo:

QuteUserTagDefinition

datho7561 commented 1 year ago

What should happen if the user tag references the parameter many times?

angelozerr commented 1 year ago

What should happen if the user tag references the parameter many times?

It go to the first definition.

datho7561 commented 1 year ago

Hmm. I think it would be nice if we could show all the places it's used in the custom tag, but maybe that's more suited for "references".

Also, if you have a type declaration of the parameter at the top of the custom tag template, it would be nice if "go to definition" went to that.

angelozerr commented 1 year ago

Hmm. I think it would be nice if we could show all the places it's used in the custom tag

Ok I close this PR, and I created a new one at https://github.com/redhat-developer/quarkus-ls/pull/792 but it is in draft because it is linked to https://github.com/redhat-developer/quarkus-ls/pull/791 (please review it before).

angelozerr commented 1 year ago

Hmm. I think it would be nice if we could show all the places it's used in the custom tag, but maybe that's more suited for "references".

Please see the new PR https://github.com/redhat-developer/quarkus-ls/pull/794