redhat-developer / quarkus-ls

Language server for Quarkus tooling
Eclipse Public License 2.0
43 stars 15 forks source link

Add CodeAction to insert expected input for renarde #form #793

Closed JessicaJHee closed 1 year ago

JessicaJHee commented 1 year ago

Fixes #778

Signed-off-by: Jessica He jhe@redhat.com

angelozerr commented 1 year ago

Please fix conflicts

angelozerr commented 1 year ago

@JessicaJHee the RestParam required is filled as false every time https://github.com/redhat-developer/quarkus-ls/blob/4f65ede9b3aa760aa26d30f197dafc073c477cd0/qute.jdt/com.redhat.qute.jdt/src/main/java/com/redhat/qute/jdt/internal/extensions/renarde/RenardeResolvedJavaTypeFactory.java#L150

You need to take care of @NotBlank (ex : @RestForm @NotBlank String userName,) to updat ecorrectly the required flag.

JessicaJHee commented 1 year ago

Works now but I still need to take care of tabs/indent properly. Thank you very much for the review and suggestion so far Angelo!

angelozerr commented 1 year ago

Works now but I still need to take care of tabs/indent properly.

Ok I'm waiting for that you implement this feature. I did new (few) reviews but your code looks very great.

Thank you very much for the review and suggestion so far Angelo!

You are welcome!

JessicaJHee commented 1 year ago

There is currently a temporary solution for this code action to insert the correct indentation that should be improved in a future PR by implementing QuteFormattingSettings. Peek 2023-02-16 14-21

angelozerr commented 1 year ago

@FroMage please see the demo below, I think this feature will please you:) Thanks @JessicaJHee !

FroMage commented 1 year ago

WOW great!

BTW, I'm currently working on I18N and this might be interesting for you as well, for new IDE features 😇

angelozerr commented 1 year ago

WOW great!

Glad you like it :)

BTW, I'm currently working on I18N and this might be interesting for you as well, for new IDE features

Don't hesitate to create any issue for supporting your new feature by explaning your ideas!

angelozerr commented 1 year ago

It works like a charm @JessicaJHee , great work!!!