search

redhat-developer / quarkus-ls

Language server for Quarkus tooling
Eclipse Public License 2.0
43 stars 15 forks source link

Definition for user tag parameter #794

Closed angelozerr closed 1 year ago

angelozerr commented 1 year ago

Definition for user tag parameter

Fixes #789

Signed-off-by: azerr azerr@redhat.com

datho7561 commented 1 year ago

IMO it makes more sense for this to be references instead of definition. What do you think?

angelozerr commented 1 year ago

IMO it makes more sense for this to be references instead of definition. What do you think?

I think it is a definition and not references. The user tag my.html file declares some expression with object part (ex : {name}) and the template uses the declaration {#my name="" }

In the future we could implement find references on {name} of the user tag my.html which will report all #my user tag which have name parameter.

datho7561 commented 1 year ago

Okay

datho7561 commented 1 year ago

(the test are failing for an unrelated issue that I'll look into addressing, so I'll merge this for now).