Support Jakarta namespace for Quarkus 3

redhat-developer / quarkus-ls

Language server for Quarkus tooling

Eclipse Public License 2.0

43 stars 15 forks source link

Support Jakarta namespace for Quarkus 3 #799

Closed datho7561 closed 1 year ago

datho7561 commented 1 year ago

Closes #779

Signed-off-by: David Thompson davthomp@redhat.com

datho7561 commented 1 year ago

I should include tests that test the changes with a Quarkus 3 project, although it would probably be a good idea to wait until Quarkus 3 is released in order to do that.

datho7561 commented 1 year ago

@maxandersen This PR is to fix support for Quarkus 3 in vscode-quarkus. (It's fixes related to the jakarta namespace migration for features in the qute templating support). It still needs a bit of work, and currently I'm writing integration tests on a Quarkus project using one of the alpha builds. How far out is the Quarkus 3 release? I'm wondering if I should hold off on this until a release/release candidate version of Quarkus 3 is available.

maxandersen commented 1 year ago

I would put it in as soon as possible to make it easy to try out. As long as it can still work with quarkus 2 :)

datho7561 commented 1 year ago

Okay. Sounds good. I'll get this polished up and merged.

datho7561 commented 1 year ago

Just to explain what's changed in this PR:

Referencing a @Named bean from a template using inject:NameOfBean should work for Quarkus 3 projects
If you add @Vetoed or @Decorator (from jakarta the namespace) to your @Named bean, you will no longer be able to reference it in a template, since adding these annotations prevents the class from being a bean class. (this already worked for @Vetoed and @Decorator from javax)

angelozerr commented 1 year ago

It works great, thanks @datho7561 !