redhat-developer / quarkus-ls

Language server for Quarkus tooling
Eclipse Public License 2.0
43 stars 15 forks source link

Show validation errors for Qute project without opening a Qute template file #819

Closed angelozerr closed 1 year ago

angelozerr commented 1 year ago

Show validation errors for Qute project without opening a Qute template file

Fixes #813

This PR requires https://github.com/redhat-developer/vscode-quarkus/pull/597 on vscode side

angelozerr commented 1 year ago

To test this PR, your workspace need to have a Qute project and you need to close all files. Reopen your vscode and you should see:

I have implemented quickly the LSP progress support. The progress appears on the left of the vscode (and not of the right like Java popup)

Here a demo:

QuteLoadProjectProgress

angelozerr commented 1 year ago

@JessicaJHee @datho7561 please review this PR and don't forget to use this PR too https://github.com/redhat-developer/vscode-quarkus/pull/597 on vscode side

JessicaJHee commented 1 year ago

Oh shoot I didn't realize it's already merged, the comments were mostly optional and the change works well!

angelozerr commented 1 year ago

Oh shoot I didn't realize it's already merged, the comments were mostly optional and the change works well!

I will create a little PR to fix your very good review.