search

redhat-developer / quarkus-ls

Language server for Quarkus tooling
Eclipse Public License 2.0
44 stars 15 forks source link

Tests for Renarde REST methods with no annotations #824

Closed datho7561 closed 1 year ago

datho7561 commented 1 year ago

Modifies the Renarde WorkspaceSymbol and CodeLens test cases in order to test that those features work on methods without any annotations on them.

Requires eclipse/lsp4mp#376

Signed-off-by: David Thompson davthomp@redhat.com

angelozerr commented 1 year ago

@datho7561 I wanted to merge this PR,but CI build is failing, but I think it is not related to your PR.

datho7561 commented 1 year ago

I think it's because the SNAPSHOT of the lsp4mp change that fixes the test case hadn't been published yet. I scheduled a rerun of the tests.

datho7561 commented 1 year ago

Never mind. QuteDiagnosticsInProjectWithoutLSPDidChangeWatchedFilesTest failed twice in a row on my computer.

angelozerr commented 1 year ago

Could you check if there are some deled html files in the src/test/resources folder?

datho7561 commented 1 year ago

I don't think there are deleted files, unless they are not tracked by git. I'll try running git clean -f . to see if that changes anything.

datho7561 commented 1 year ago

Nope, the tests are passing for me locally.

angelozerr commented 1 year ago

I have restarted CI build and now is working, I merged the PR. Thanks @datho7561 !