search

redhat-developer / quarkus-ls

Language server for Quarkus tooling
Eclipse Public License 2.0
44 stars 15 forks source link

Add CodeActions to resolve syntax errors related to sections #838

Closed JessicaJHee closed 1 year ago

JessicaJHee commented 1 year ago

Fixes #821

JessicaJHee commented 1 year ago

Currently for the UNTERMINATED_SECTION code action, I insert the section end tag after any child content. I'm not sure if this is this best approach or the end tag should be generated fight after the start tag.

This is the current behavior:

Peek 2023-03-29 12-42

angelozerr commented 1 year ago

@JessicaJHee your PR looks very good.

I would like to merge my PR https://github.com/redhat-developer/quarkus-ls/pull/832 before yours and as I did some refactoring you will need to change your code (JavaDataModelCache has changed and now code action uses QuteProjectRegistry instead). The resolveJavaType is done with project and not with java data model cache.

angelozerr commented 1 year ago

@JessicaJHee please fix conflict

angelozerr commented 1 year ago

I love your work @JessicaJHee, thanks so much!