redhat-developer / quarkus-ls

Language server for Quarkus tooling
Eclipse Public License 2.0
44 stars 15 forks source link

Remove unexpected nested-content parameter inserted in Quick Fix #846

Closed JessicaJHee closed 1 year ago

JessicaJHee commented 1 year ago

Fixes #841

datho7561 commented 1 year ago

Looks pretty good, but there is a related corner case:

If you have a user tag myTag.html:

{it}

and you reference it:

{#myTag}
{/myTag}

I'm wondering if you want to address this in this PR or should I file an issue so that someone will eventually get to it?

JessicaJHee commented 1 year ago

Thank you for pointing this case out! I've made some changes and added a test case, please let me know if I've understood the problem correctly.

datho7561 commented 1 year ago

PR seems to be good, but there are test failures: it seems like adding a new user tag to one of the test projects affected a test that counts the number of completion items.