search

redhat-developer / quarkus-ls

Language server for Quarkus tooling
Eclipse Public License 2.0
44 stars 15 forks source link

Ignore 'UndefinedObject' + 'UndefinedNamespace' problem code action should appear only if LSP client can support update configuration. #862

Closed angelozerr closed 1 year ago

angelozerr commented 1 year ago

Ignore 'UndefinedObject' problem code action should appear only if LSP client can support update configuration.

In IJ Quarkus, it doesn't support the capability to update configuration on client side. In otherwise the Ignore 'UndefinedObject' problem should not appear:

image

This PR checks that LSP client can support the command which update LSP client settings.

datho7561 commented 1 year ago

This causes the tests to fail, since in the tests we expect the code action to appear, and it doesn't

angelozerr commented 1 year ago

Once the tests are fixed, I think this will be good to merge

Indeed I need to fix tests.

angelozerr commented 1 year ago

@datho7561 tests should be fixed and I missed to do the same thing for UndefinedNamespace.

angelozerr commented 1 year ago

@datho7561 it seems that there is a problem with snapshot https://github.com/redhat-developer/quarkus-ls/actions/runs/4757288906/jobs/8453919530#step:7:443

datho7561 commented 1 year ago

it seems that there is a problem with snapshot

Right, we need to point to lsp4mp 0.8.0-SNAPSHOT, since the snapshots for 0.7.0 are deleted after a certain amount of time.