search

redhat-developer / quarkus-ls

Language server for Quarkus tooling
Eclipse Public License 2.0
44 stars 15 forks source link

No section helper found #869

Open fbricon opened 1 year ago

fbricon commented 1 year ago

As seen in https://github.com/ia3andy/renotes/blob/web-bundler/src/main/resources/templates/main.html#L5 and https://github.com/ia3andy/renotes/blob/web-bundler/src/main/resources/templates/main.html#L18

Screenshot 2023-05-15 at 17 02 04

Either our validation is too strict, or it's correct and @ia3andy's code is wrong (I doubt it).

@ia3andy's renotes app (web-bundler branch) requires Quarkus Web Bundler to first be cloned and built locally (mvn install -DskipTests) NO LONGER NECESSARY

angelozerr commented 1 year ago

This user tag comes from https://github.com/quarkiverse/quarkus-web-bundler/tree/main/runtime/src/main/resources/templates in otherwise from a JAR and it should work if the JAR contains user tags and if this the maven dependency is declared correctly.

@ia3andy are you sure that your quarkus Web bundler contains those user tags in the same mean than renarde

ia3andy commented 1 year ago

@angelozerr I don't see any difference yes

Also did you see that web/components/**/*.html was containing some new tags. This is a new feature of the web-bundler extension so it's normal if it's not supported yet.

angelozerr commented 1 year ago

@ia3andy you mean that html files coming from web/components/*/.html should be considered as user tags?

If yes what is the rule to consider that thise files are Qute user tags? Today we scan all html files from src/main/resources/templates/tags and templates/tags from JAR

angelozerr commented 1 year ago

I tested with vscode-quarkus, and the section can be found but there is an error because bundle and name cannot be found?

image

For name, it seems the used syntax is name?, it seems that we don't take care of this usecase.

For bundle, I have the impression that it is hard coded something and it means that we need to creat a custom support for quarkus-web-bundler.

Indeed when I see https://github.com/quarkiverse/quarkus-web-bundler/blob/52d967853c2d50aa98e99d201d747f0e98bc4c6b/runtime/src/main/java/io/quarkiverse/web/bundler/runtime/qute/WebAssetsQuteEngineObserver.java#L48

User tags folder are hard coded and doesn't use the standatd src/main/resources/templates/tags folder.

In other words we need to provide a support for Quarkus Web Bundler by hard coding the support like we did for Renarde with uri/uriabs.

@ia3andy could you create an issue like Quarkus Web Bundler support and explain us how to manage bundle and scan which folders to collect Quarkus Web Bundler tags. Thanks!

angelozerr commented 1 year ago

I tried with IJ Quarkus and indeed we have the problem No section helper found, it is a problem with IJ Quarku snot with Qute LS.

@ia3andy do you try with vscode-quarkus or with IJ Quarkus?