search

redhat-developer / quarkus-ls

Language server for Quarkus tooling
Eclipse Public License 2.0
43 stars 15 forks source link

detected path in plugin are not following renarde paths spec #892

Closed ia3andy closed 1 year ago

ia3andy commented 1 year ago

See spec: https://quarkiverse.io/quarkiverse-docs/quarkus-renarde/dev/index.html#_methods

with 

@Path("/game")
public class GameController extends HxController
image

it should be /game/{id}

I also find the spec a bit weird but there might be a reason for it cc @fromage

fbricon commented 1 year ago

@ia3andy can you check with vscode-quarkus? It might be supported already but some work needs to be ported to intellij

ia3andy commented 1 year ago

I can have a look next week, this week is really busy

fbricon commented 1 year ago

The leading "/" overrides the global path. Try with "{id}", as in

Screenshot 2023-07-05 at 12 26 22
ia3andy commented 1 year ago

@fbricon look at the spec in Renarde:

image
fbricon commented 1 year ago

Yes it's a bug specifically with the Renarde integration:

Jul-05-2023 12-41-52

fbricon commented 1 year ago

https://github.com/redhat-developer/quarkus-ls/pull/894 should fix it for Eclipse-based tools, but I need to make the equivalent fix in intellij-quarkus. EDIT: done at https://github.com/redhat-developer/intellij-quarkus/pull/991