redhat-developer / quarkus-ls

Language server for Quarkus tooling
Eclipse Public License 2.0
44 stars 15 forks source link

Improve performance of compute of Qute data model with binary #899

Open angelozerr opened 1 year ago

angelozerr commented 1 year ago

Today when a Java source file is saved, it evicts the Java cache of Qute which stores information of Java source and binary classes (ex : Integer String have some methods) to use it with completion.

It means that each time you save a Java file source (in IJ it is not on saved but on change of Java file), it evict the cache from Java sources and binary classes and it compute again the data model from sources and binary (ex : it scans JAR to collect Qute renarde user tags, it collect again methods of String).

You can notice that by seeing LSP console which collect information about String, Collection, etc after a Java source change although the cache should not evict binary classes:

..

[Trace - 01:45:50 PM] Received request 'qute/template/resolvedJavaType - (54)'
Params: {
  "className": "java.util.List",
  "projectUri": "quarkus-blast"
}

[Trace - 01:45:50 PM] Received request 'qute/template/resolvedJavaType - (60)'
Params: {
  "className": "java.util.Collection",
  "projectUri": "quarkus-blast"
}

[Trace - 01:45:50 PM] Received request 'qute/template/resolvedJavaType - (61)'
Params: {
  "className": "java.util.Collection",
  "projectUri": "quarkus-blast"
}

[Trace - 01:45:50 PM] Received request 'qute/template/resolvedJavaType - (62)'
Params: {
  "className": "java.lang.Iterable",
  "projectUri": "quarkus-blast"
}

[Trace - 01:45:50 PM] Received request 'qute/template/resolvedJavaType - (63)'
Params: {
  "className": "java.lang.Iterable",
  "projectUri": "quarkus-blast"
}

[Trace - 01:45:50 PM] Received request 'qute/template/resolvedJavaType - (64)'
Params: {
  "className": "java.util.Collection",
  "projectUri": "quarkus-blast"
}

[Trace - 01:45:50 PM] Received request 'qute/template/resolvedJavaType - (65)'
Params: {
  "className": "java.lang.Iterable",
  "projectUri": "quarkus-blast"
}

The evict cache must be improved to evict only data model of Java sources and not of binary when a Java file is saved.