redhat-developer / quarkus-ls

Language server for Quarkus tooling
Eclipse Public License 2.0
44 stars 15 forks source link

Qute now support optional end tags for sections #902

Closed angelozerr closed 11 months ago

angelozerr commented 11 months ago

Qute now support optional end tags for sections

Fixes #879

angelozerr commented 11 months ago

To try this PR, open https://github.com/ia3andy/quarkus-blast/blob/main/src/main/resources/templates/GameController/game.html

datho7561 commented 11 months ago

If you make the following change to the file (use {#let ...} in an {#if} block) :

diff --git a/src/main/resources/templates/GameController/game.html b/src/main/resources/templates/GameController/game.html
index bff6b4e..721483c 100644
--- a/src/main/resources/templates/GameController/game.html
+++ b/src/main/resources/templates/GameController/game.html
@@ -3,6 +3,7 @@
   {#if game}
     <div class="text-center game-container d-flex flex-grow-1 flex-column">
       <div class="flex-grow-1 justify-content-center d-flex flex-column order-lg-1">
+        {#let sandwich='salami'}
         {#include GameController/partials/grid.html}{/include}
         {#include GameController/partials/score.html}{/include}
       </div>

Then I get the following diagnostic:

Parser error: unterminated section [else] detected
angelozerr commented 11 months ago

Good catch! Let me try fixing that.

angelozerr commented 11 months ago

@datho7561 please retry it

JessicaJHee commented 11 months ago

@angelozerr I noticed the same problem and can confirm now it is fixed!

angelozerr commented 11 months ago

@angelozerr I noticed the same problem and can confirm now it is fixed!

Thanks for your feedback!

angelozerr commented 11 months ago

Ok CI build is working again.

angelozerr commented 11 months ago

Thanks @datho7561 @JessicaJHee for your review!