search

redhat-developer / quarkus-ls

Language server for Quarkus tooling
Eclipse Public License 2.0
43 stars 15 forks source link

fix: use newer JDT.LS's JavadocContentAccess2 methods #949

Closed fbricon closed 8 months ago

fbricon commented 8 months ago

Fixes javadoc for qute, similar to https://github.com/eclipse/lsp4mp/pull/432.

Related to https://github.com/redhat-developer/vscode-quarkus/issues/638

fbricon commented 8 months ago

Plenty of test failures like: 

Errors: 
  ConfigItemIntBoolDefaultValueTest.configItemIntBoolDefaultValueTest:36->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  MicroProfileConfigPropertyTest.configQuickstartFromClasspath:34->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  MicroProfileConfigPropertyTest.configQuickstartFromJavaSources:114->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  PropertiesManagerClassPathKindTest.configQuickstartTest:65 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  PropertiesManagerTest.quarkusCorePropertiesWithOnlyCore:57->quarkusCoreTest:73 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusConfigPropertiesTest.configPropertiesNoDefaultNamingStrategy:56 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusConfigPropertiesTest.configPropertiesVerbatimDefaultNamingStrategy:180 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusConfigRootTest.allQuarkusExtensions:67->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:123->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusConfigRootTest.configQuickStart:174->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusConfigRootTest.hibernateOrmResteasy:45->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:123->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusHibernateORMPropertyTest.quarkusContainerImages:34->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusKubernetesTest.docker:159->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:123->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusKubernetesTest.kubernetes:35->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:123->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusKubernetesTest.openshift:82->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:123->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusKubernetesTest.s2i:123->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:123->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusScheduledPropertiesTest.configQuickstartFromClasspath:29->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  QuarkusScheduledPropertiesTest.configQuickstartFromJavaSources:46->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusCachePropertiesTest.cacheQuickstartFromClasspath:35->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  JavaCodeLensQuarkusRestClientTest.urlCodeLensYaml:46 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusConfigJavaDefinitionTest.configPropertyNameDefinitionYml:57 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusConfigJavaHoverTest.configPropertyNameRespectsPrecendence:53 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusConfigJavaHoverTest.configPropertyNameYaml:100 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusConfigJavaHoverTest.configPropertyNameYml:143 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusConfigJavaHoverTest.perProfileConfigPropertyFile:185 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusConfigMappingTest.configMapping:34->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusContainerImagesTest.quarkusContainerImages:36->BasePropertiesManagerTest.getMicroProfileProjectInfoFromMavenProject:130 » NoSuchMethod 'void org.eclipse.jdt.internal.core.search.JavaSearchScope.add(org.eclipse.jdt.internal.core.JavaProject, int, java.util.HashSet)'
  JaxRsApplicationPathCodeLensTest.urlCodeLensProperties:53->assertCodeLenses:62 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  JaxRsCodeLensTest.urlCodeLensProperties:51->assertCodeLenses:139 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  JaxRsCodeLensTest.urlCodeLensYaml:107->assertCodeLenses:139 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  RenardeJaxRsTest.absolutePathCodeLens:67 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  RenardeJaxRsTest.codeLens:48 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  RenardeJaxRsTest.workspaceSymbols:78 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusScheduledDefinitionTest.configCronPropertyDefinition:53 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusScheduledDefinitionTest.configEveryPropertyNameDefinition:71 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusScheduledDefinitionTest.configPropertyExpressionDefinition:89 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusScheduledHoverTest.configFirstPropertyNameHover:52 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusScheduledHoverTest.configPropertyExpressionHover:88 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'
  QuarkusScheduledHoverTest.configSecondPropertyNameHover:70 » NoSuchMethod 'java.lang.Object org.eclipse.jdt.internal.core.JavaModelManager.getInfo(org.eclipse.jdt.core.IJavaElement)'

Caused by 2-week old refatoring https://github.com/eclipse-jdt/eclipse.jdt.core/commit/4556ac22b87bd69828fed9fbcf8ce24c24fad2ec#diff-1999f63d81fb3fd59a1d400627b6dc3eb4dab002248a599d172996e909ce007aR104

jdt.core changing method signatures by adding generics, making it binary incompatible with the lsp4mp bits compiled against previous signatures.