search

redhat-developer / quarkus-ls

Language server for Quarkus tooling
Eclipse Public License 2.0
43 stars 15 forks source link

Version 18 release duplicate key issue #988

Closed angelozerr closed 1 month ago

angelozerr commented 1 month ago

Version 18 release duplicate key issue

Fixes https://github.com/redhat-developer/vscode-quarkus/issues/822

fbricon commented 1 month ago

tests are failing, better fix those before merging

datho7561 commented 1 month ago

I confirmed that I was able to reproduce the bug using the sample project, and this PR fixes that bug. I'm going to try running the test suite locally to see if I the results are any different locally.

angelozerr commented 1 month ago

tests are failing, better fix those before merging

I change the strategy by checking if parameter exists before to add it.

angelozerr commented 1 month ago

I confirmed that I was able to reproduce the bug using the sample project, and this PR fixes that bug. I'm going to try running the test suite locally to see if I the results are any different locally.

Thanks to review it.

I have changed my code, it should work better now (I hope).

angelozerr commented 1 month ago

CI build is working again and it fixes a test that I had to updated.

@datho7561 please retry it and if you think it is good, please merge it.